[PATCH 2/3] drm: qxl: Open code probing sequence for qxl

Gabriel Krisman Bertazi krisman at collabora.co.uk
Tue Jan 17 13:15:15 UTC 2017


Gustavo Padovan <gustavo at padovan.org> writes:

> I'm not confortable with exposing minor->type here and making qxl
> the first driver to use it outside of drm core. Don't we have any other
> way. 
>
> I see that inside qxl_debugfs_add_files() we have a check for already
> registered files. Wouldn't that or some modification around work for
> this?

Thanks for your review, Gustavo.

As I mentioned on IRC, I verified the check is not needed at all,
since qxl only implements one minor.  I'll resend without this bit.

-- 
Gabriel Krisman Bertazi


More information about the dri-devel mailing list