[PATCH] drm: Update drm_cache.c to pull in the new drm_cache.h

Gabriel Krisman Bertazi krisman at collabora.co.uk
Sat Jan 21 20:05:05 UTC 2017


Chris Wilson <chris at chris-wilson.co.uk> writes:

> The prototypes were moved to a new header, but the function definitions
> were not updated to pull in the declarations.
>
> drivers/gpu/drm/drm_cache.c:79:1: warning: no previous prototype for ‘drm_clflush_pages’ [-Wmissing-prototypes]
> drivers/gpu/drm/drm_cache.c:120:1: warning: no previous prototype for ‘drm_clflush_sg’ [-Wmissing-prototypes]
> drivers/gpu/drm/drm_cache.c:152:1: warning: no previous prototype for ‘drm_clflush_virt_range’ [-Wmissing-prototypes]
>
> Fixes: f9a87bd7d5b6 ("drm: Move drm_clflush prototypes to drm_cache header file")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Gabriel Krisman Bertazi <krisman at collabora.co.uk>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>

Patch is good, though I'm Embarrassed that I didn't have -Wmissing-prototypes
enabled when testing this.  Thanks Chris.

Reviewed-by: Gabriel Krisman Bertazi <krisman at collabora.co.uk>

--
Gabriel Krisman Bertazi


More information about the dri-devel mailing list