[RFC PATCH v2 0/5] Add vblank hooks to struct drm_crtc_funcs

Shawn Guo shawnguo at kernel.org
Sun Jan 22 06:09:01 UTC 2017


From: Shawn Guo <shawn.guo at linaro.org>

The vblank is mostly CRTC specific and implemented as part of CRTC
driver.  The first patch adds 3 vblank core-driver hooks into struct
drm_crtc_funcs, and wraps around core vblank handling code to use the
new hooks for modern MODESET drivers and the ones in struct drm_driver
as fallback for legacy drivers.

The other patches in the series are to demonstrate how the new hooks
are going to influence the driver code.  There are more drivers than
the ones included here can be converted.  But before doing that, I would
like to get some feedbacks first, expecially on how .get_vblank_counter
should be converted when it's being drm_vblank_no_hw_counter().

	.get_vblank_counter = drm_vblank_no_hw_counter

The series is generated against branch drm-misc-next.

Changes for v2:
 - Wrap around core vblank handling code to save
   drm_crtc_enable[disable]_vblank() helpers
 - Add .get_vblank_counter to struct drm_crtc_funcs
 - Add some comments to link between two sets of hooks
 - Add one hdlcd driver patch for example

Shawn Guo (5):
  drm: add vblank hooks to struct drm_crtc_funcs
  drm: hdlcd: use vblank hooks in struct drm_crtc_funcs
  drm: zte: zx_vou_enable[disable]_vblank can be static
  drm: rockchip: remove struct rockchip_crtc_funcs
  drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs

 drivers/gpu/drm/arm/hdlcd_crtc.c            |  20 ++++++
 drivers/gpu/drm/arm/hdlcd_drv.c             |  20 ------
 drivers/gpu/drm/drm_irq.c                   |  53 +++++++++++++--
 drivers/gpu/drm/imx/imx-drm-core.c          | 101 ----------------------------
 drivers/gpu/drm/imx/imx-drm.h               |  13 ----
 drivers/gpu/drm/imx/ipuv3-crtc.c            |  58 ++++++----------
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c |  51 --------------
 drivers/gpu/drm/rockchip/rockchip_drm_drv.h |  14 ----
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c |   9 +--
 drivers/gpu/drm/zte/zx_drm_drv.c            |   2 -
 drivers/gpu/drm/zte/zx_vou.c                |  61 +++++++----------
 drivers/gpu/drm/zte/zx_vou.h                |   3 -
 include/drm/drm_crtc.h                      |  34 ++++++++++
 include/drm/drm_drv.h                       |   9 +++
 14 files changed, 157 insertions(+), 291 deletions(-)

-- 
1.9.1



More information about the dri-devel mailing list