[PATCH] drm/exynos: fix a timeout loop

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 23 09:41:01 UTC 2017


On Mon, Jan 23, 2017 at 06:32:16PM +0900, Inki Dae wrote:
> 
> 
> 2017년 01월 21일 01:54에 Tobias Jakobi 이(가) 쓴 글:
> > From: Dan Carpenter <dan.carpenter at oracle.com>
> > 
> > We were trying to print an error message if we timed out here, but the
> > loop actually ends with "tries" set to UINT_MAX and not zero.  Fix this
> > by changing from tries-- to --tries.
> 
> Sorry but I already know this patch from long ago but I'm not clear yet.
> How the variable, tries, could have UNIT_MAX?

The value of tries after the final loop is -1u. The WARN fires on a
succesful read on the final loop, instead of the complete failure.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list