[radeon-alex:amd-staging-4.9 474/507] drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:390:28: sparse: incompatible types in comparison expression (different signedness)

kbuild test robot fengguang.wu at intel.com
Tue Jan 24 00:59:38 UTC 2017


tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-4.9
head:   efa90756f6e447a7e4133b271e10597078fb58fc
commit: 6d8d2b46e5accb74ce71c834aa95ef5ec9eaa9df [474/507] drm/amdgpu: user BO priority instead of self coding it
reproduce:
        # apt-get install sparse
        git checkout 6d8d2b46e5accb74ce71c834aa95ef5ec9eaa9df
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address': unknown attribute
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:390:28: sparse: incompatible types in comparison expression (different signedness)
   In file included from include/linux/list.h:8:0,
                    from drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:32:
   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function 'amdgpu_bo_create_restricted':
   include/linux/kernel.h:739:16: warning: comparison of distinct pointer types lacks a cast
     (void) (&min1 == &min2);   \
                   ^
   include/linux/kernel.h:742:2: note: in expansion of macro '__min'
     __min(typeof(x), typeof(y),   \
     ^~~~~
   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:390:21: note: in expansion of macro 'min'
     bo->tbo.priority = min(bo->tbo.priority, TTM_MAX_BO_PRIORITY - 1);
                        ^~~

vim +390 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

   374	
   375		if (!resv) {
   376			bool locked;
   377	
   378			reservation_object_init(&bo->tbo.ttm_resv);
   379			locked = ww_mutex_trylock(&bo->tbo.ttm_resv.lock);
   380			WARN_ON(!locked);
   381		}
   382		r = ttm_bo_init(&adev->mman.bdev, &bo->tbo, size, type,
   383				&bo->placement, page_align, !kernel, NULL,
   384				acc_size, sg, resv ? resv : &bo->tbo.ttm_resv,
   385				&amdgpu_ttm_bo_destroy);
   386		if (unlikely(r != 0))
   387			return r;
   388	
   389		bo->tbo.priority = ilog2(bo->tbo.num_pages);
 > 390		bo->tbo.priority = min(bo->tbo.priority, TTM_MAX_BO_PRIORITY - 1);
   391	
   392		if (flags & AMDGPU_GEM_CREATE_VRAM_CLEARED &&
   393		    bo->tbo.mem.placement & TTM_PL_FLAG_VRAM) {
   394			struct fence *fence;
   395	
   396			r = amdgpu_fill_buffer(bo, 0, bo->tbo.resv, &fence);
   397			if (unlikely(r))
   398				goto fail_unreserve;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


More information about the dri-devel mailing list