[PATCH libdrm 2/3] amdgpu: don't mess with shared_handle if amdgpu_bo_import() fails

Emil Velikov emil.l.velikov at gmail.com
Tue Jan 24 03:53:53 UTC 2017


On 23 January 2017 at 16:14, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> I don't think is correct. The incoming handle is in shared_handle, not in
> handle. Once the code block around line 310 has executed, shared_handle is
> the handle produced by drmPrimeFDToHandle, and closing it on error (as the
> code currently does) should be the correct thing to do.
>
I've got confused with the shared_handle <> handle naming - read the
wrong one where I shouldn't have ;-)

You're spot on. Thanks for the correction.
Emil


More information about the dri-devel mailing list