Warning at drivers/gpu/drm/drm_atomic_helper.c

[Lucas Stach]

Am Sonntag, den 22.01.2017, 23:10 -0200 schrieb Fabio Estevam:
> On Sun, Jan 22, 2017 at 12:26 PM, Fabio Estevam <festevam at gmail.com> wrote:
> > On Sat, Jan 21, 2017 at 2:40 PM, Fabio Estevam <festevam at gmail.com> wrote:
> >> Hi,
> >>
> >> Stopping kmscube application on mx6q through CTRL + C sometimes leads
> >> to the following kernel warning:
> >>
> >> ^C[ 3939.785516] ------------[ cut here ]------------
> >> [ 3939.790313] WARNING: CPU: 1 PID: 67 at
> >> drivers/gpu/drm/drm_atomic_helper.c:1032
> >> drm_atomic_helper_wait_for_fences+0xe4/0x104
> >> [ 3939.801626] Modules linked in:
> >> [ 3939.804762] CPU: 1 PID: 67 Comm: kworker/1:1 Tainted: G        W
> >>    4.9.4 #1
> >
> > Just tested 4.9.5 and the kernel warning is gone.
> 
> Actually 4.9.5 shows the same warning.
> 
> If I change .atomic_commit like in 782ea2a493ba90800 ("drm/imx: Switch
> to drm_fb_cma_prepare_fb() helper") from 4.10-rc1
> 
> -       .atomic_commit = imx_drm_atomic_commit,
> +       .atomic_commit = drm_atomic_helper_commit,
> 
> it fixes the problem.

This only fixes the issue, as with this change we never attach fences to
the plane state. I've looked into this issue a bit and if I'm not
mistaken, this should still be reproducible with 4.10-rc. Correct?

In that case I'll cook up a patch for you to test.

Regards,
Lucas