[PATCH libdrm] tests: Use -pthread in CFLAGS instead of -lpthread

Emil Velikov emil.l.velikov at gmail.com
Fri Jan 27 16:10:07 UTC 2017


On 27 January 2017 at 07:21, Tomasz Figa <tfiga at chromium.org> wrote:
> -lpthread is not always a valid flag to pull pthread support, especially
> on Android it will fail to link due to a missing libpthread.so. The more
> generic way to build-in pthread support is to use the -pthread CFLAG, so
> let's use it instead.
>
Afaict this might cause an issue on BSD/Solaris platforms, but afaict
neither of which builds the code in question.
With that said I'll land this shortly.

Whist looking through Solaris repos, there's a lot of
patches/workarounds many of which should be fine to land - be that on
Mesa and/or libdrm side.
Randy, Niveditha can I interest you in sending patches upstream as
soon as you [others in the team] spot issues ? Even if you think that
they're hacks/will be rejected/etc. Please ?
Adding note for each patch why it's not in is a very good idea ;-)

Note - if you need GNU_MAKE, extra defines, etc. workarounds that's a
giveaway that something on our end is broken. Please report and/or
send us patches.

Thanks !
Emil


More information about the dri-devel mailing list