[PATCH 08/10] drm/etnaviv: make it possible to reconfigure perf counter

Russell King - ARM Linux linux at armlinux.org.uk
Mon Jan 30 23:40:54 UTC 2017


On Mon, Jan 30, 2017 at 12:01:18PM +0100, Lucas Stach wrote:
> Am Freitag, den 09.12.2016, 12:21 +0100 schrieb Christian Gmeiner:
> > -		if (r->flags) {
> > -			DRM_ERROR("readback flags not 0");
> > +		if (r->flags > ETNA_READBACK_PERF) {
> > +			DRM_ERROR("invalid readback flags");

This test should be more robust - while ETNA_READBACK_PERF may have a
value of '1', this is not how we should be checking for invalid _flags_.
It may work, but it's not the best solution.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.


More information about the dri-devel mailing list