[PATCH v2 19.1/25] drm/bridge/mhl: add MHL3 infoframe related definitions

[Archit Taneja]

On 01/26/2017 07:20 PM, Andrzej Hajda wrote:
> MHL3 protocol uses vendor specific infoframes to transmit additional
> information to the sink. This patch adds definitions of structures and
> constants used to create such frames.
>
> Signed-off-by: Andrzej Hajda <a.hajda at samsung.com>
> ---
>  include/drm/bridge/mhl.h | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/include/drm/bridge/mhl.h b/include/drm/bridge/mhl.h
> index 71d922f..8dfa2cd 100644
> --- a/include/drm/bridge/mhl.h
> +++ b/include/drm/bridge/mhl.h
> @@ -339,4 +339,36 @@ struct mhl_burst_audio_descr {
>  	u8 short_desc[9];
>  } __packed;
>
> +/*
> + * MHL3 infoframe related definitions
> + */
> +
> +#define MHL3_IEEE_OUI		0x7ca61d
> +#define MHL3_INFOFRAME_SIZE	15
> +
> +enum mhl3_video_format {
> +	mhl3_video_format_none,
> +	mhl3_video_format_3d,
> +	mhl3_video_format_multi_view,
> +	mhl3_video_format_dual_3d
> +};
> +
> +enum mhl3_3d_format_type {
> +	mhl3_3d_format_type_fs, /* frame sequential */
> +	mhl3_3d_format_type_tb, /* top-bottom */
> +	mhl3_3d_format_type_lr, /* left-right */
> +	mhl3_3d_format_type_fs_tb, /* frame sequential, top-bottom */
> +	mhl3_3d_format_type_fs_lr, /* frame sequential, left-right */
> +	mhl3_3d_format_type_tb_lr /* top-bottom, left-right */
> +};
> +

Can we keep the enums in caps?

Thanks,
Archit

> +struct mhl3_infoframe {
> +	unsigned char version;
> +	enum mhl3_video_format video_format;
> +	enum mhl3_3d_format_type format_type;
> +	bool sep_audio;
> +	int hev_format;
> +	int av_delay;
> +};
> +
>  #endif /* __MHL_H__ */
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project