[PATCH 08/13] drm/fb-helper: Stop using mode_config.mutex for internals

Daniel Vetter daniel.vetter at ffwll.ch
Tue Jul 4 16:19:20 UTC 2017


On Tue, Jul 4, 2017 at 5:40 PM, Ville Syrjälä
<ville.syrjala at linux.intel.com> wrote:
>> +     mutex_lock(&fb_helper->dev->mode_config.mutex);
>>       drm_enable_connectors(fb_helper, enabled);
>> +     if (drm_fb_helper_probe_connector_modes(fb_helper, width, height) == 0)
>
> This changes the order of these two functions calls. Looks to me like
> drm_fb_helper_probe_connector_modes() updates connector->status, and
> drm_enable_connectors() depends on it. So either these shouldn't get
> reordered or there's some not immediately obvious reason why that's OK.

I think some rebase fail somewhere ... this should indeed not get
reordered. Thanks for spotting.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list