VT console blank ignored by DRM drivers on QEMU

Daniel Vetter daniel at ffwll.ch
Mon Jul 10 14:57:47 UTC 2017


On Mon, Jul 10, 2017 at 4:41 PM, Takashi Iwai <tiwai at suse.de> wrote:
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index 12ded23f1aaf..65169a5a1bca 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -2347,8 +2347,8 @@ static int fbcon_blank(struct vc_data *vc, int blank, int mode_switch)
>                         ops->cursor_flash = (!blank);
>
>                         if (!(info->flags & FBINFO_MISC_USEREVENT))
> -                               if (fb_blank(info, blank))
> -                                       fbcon_generic_blank(vc, info, blank);
> +                               fb_blank(info, blank);
> +                               fbcon_generic_blank(vc, info, blank);

My idea was more to do this in the drm_fb_helper.c layer if the driver
can't do this, since your DE might also expect that the screen goes
blank for real.

Or we fix the drivers to do a black screen by essentially switching it
off (but that might have implications again on the UI for virtual
machines, so dunno ...).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list