[Intel-gfx] [PATCH 1/5] drm/i915/fbdev: Always forward hotplug events

Daniel Vetter daniel.vetter at ffwll.ch
Mon Jul 10 15:02:31 UTC 2017


On Mon, Jul 10, 2017 at 2:15 PM, Jani Nikula
<jani.nikula at linux.intel.com> wrote:
> On Thu, 06 Jul 2017, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
>> With deferred fbdev setup we always need to forward hotplug events,
>> even if fbdev isn't fully set up yet. Otherwise the deferred setup
>> will neer happen.
>>
>> Originally this check was added in
>>
>> commit c45eb4fed12d278d3619f1904885bd0d7bcbf036 (tag: drm-intel-next-fixes-2016-08-05)
>> Author: Chris Wilson <chris at chris-wilson.co.uk>
>> Date:   Wed Jul 13 18:34:45 2016 +0100
>>
>>     drm/i915/fbdev: Check for the framebuffer before use
>
> I just pushed
>
> commit 7581d5ca2bb269cfc2ce2d0cb489aac513167f6b
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Thu Jun 22 17:02:11 2017 +0100
>
>     drm/i915/fbdev: Check for existence of ifbdev->vma before operations
>
> which is a backport of 15727ed0d944 ("drm/i915/fbdev: Check for
> existence of ifbdev->vma before operations") to dinf.
>
> Should this patch be backported too?

No. The one check this removes is harmless in current kernels. It only
breaks the deferred fbdev setup logic, which isn't in 4.13.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list