[Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V

Manasi Navare manasi.d.navare at intel.com
Mon Jul 17 19:21:20 UTC 2017


This makes sense, it should have returned the edp ddi buf translation
table as per the Bspec.
Please add this to the commit message:
Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")

After that,
Reviewed-by: Manasi Navare <manasi.d.navare at intel.com>

Manasi


On Mon, Jul 17, 2017 at 11:21:27AM -0700, Matthias Kaehlcke wrote:
> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> Use the correct table.
> 
> The error was pointed out by this clang warning:
> 
> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>   'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>   [-Wunneeded-internal-declaration]
>     static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
> 
> Signed-off-by: Matthias Kaehlcke <mka at chromium.org>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index efb13582dc73..6fa02e6a7a9b 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv,
>  	if (dev_priv->vbt.edp.low_vswing) {
>  		if (voltage == VOLTAGE_INFO_0_85V) {
>  			*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V);
> -			return cnl_ddi_translations_dp_0_85V;
> +			return cnl_ddi_translations_edp_0_85V;
>  		} else if (voltage == VOLTAGE_INFO_0_95V) {
>  			*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V);
>  			return cnl_ddi_translations_edp_0_95V;
> -- 
> 2.13.2.932.g7449e964c-goog
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the dri-devel mailing list