[PATCH 1/3] drm/mxsfb: Use gem_free_object_unlocked

Daniel Vetter daniel at ffwll.ch
Tue Jul 18 06:31:11 UTC 2017


On Mon, Jul 17, 2017 at 11:01:33AM -0700, Eric Anholt wrote:
> Daniel Vetter <daniel.vetter at ffwll.ch> writes:
> 
> > CMA helpers are struct_mutex free, and so is the mxsfb itself. And
> > that's the only valid reason for using gem_free_object. Please read
> > the kerneldoc for this stuff :-)
> 
> I'm sure all of these came from copy and paste, not the docs.  That
> said, the CMA docs currently say:
> 
>      * Drivers using the CMA helpers should set this as their
>      * &drm_driver.gem_free_object callback.
> 
> If you drop the complaint about us reading the docs, the series is:

I did double-check the docs for the two hooks to make sure they explain
this, but forgot to check the one in the cma helpers. I'll follow-up with
a patch to rectify that.

> Reviewed-by: Eric Anholt <eric at anholt.net>

Thanks for your review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list