[PATCH] drm/cirrus: Add missing drm_connector_unregister()

Takashi Iwai tiwai at suse.de
Wed Jul 19 08:40:56 UTC 2017


On Wed, 19 Jul 2017 08:35:08 +0200,
Daniel Vetter wrote:
> 
> On Tue, Jul 18, 2017 at 04:49:33PM +0200, Takashi Iwai wrote:
> > From: Egbert Eich <eich at suse.de>
> > 
> > When destroying connector unregister it.
> > 
> > Signed-off-by: Egbert Eich <eich at suse.de>
> > Signed-off-by: Takashi Iwai <tiwai at suse.de>
> 
> drm_dev_unregister unregisters all connectors too. Explicitly calling
> drm_connector_unregister should only be needed when you
> a) screwed up your unload sequence. Get rid of ->unload and make sure you
> call drm_dev_unregister first to fix this properly
> b) hot-unplug. Doesn't apply to cirrus.
> 
> I think this can/should be just dropped.

OK, please drop this one.
Thanks for clarification!


Takashi


More information about the dri-devel mailing list