[PATCH] android: amdgpu: move asic id table to a separate file

[Mauro Rossi]

2017-07-27 10:30 GMT+02:00 Chih-Wei Huang <cwhuang at android-x86.org>:
>> 2017-07-26 17:27 GMT+02:00 Emil Velikov <emil.l.velikov at gmail.com>:
>>> On 25 July 2017 at 08:28, Chih-Wei Huang <cwhuang at android-x86.org> wrote:
>>>> Hi Mauro,
>>>> Please note AMDGPU_ASIC_ID_TABLE
>>>> should be a path in the target device (i.e., Android).
>>>> So using $(LIBDRM_TOP) is incorrect.
>>>>
>>>> Actually I've sent a fix for it about one week ago.
>>>>
>>> Did you sent v2 of the patch? I cannot see any in my inbox.
>
> OK. I re-submitted v2 patch to replace
> /etc with /system/etc.
>
> 2017-07-27 1:36 GMT+08:00 Mauro Rossi <issor.oruam at gmail.com>:
>> This one has conceptual error and is to be dropped.
>>
>> The ones submitted by Chih-Wei are here:
>>
>> https://github.com/maurossi/drm/commits/2.4.82_android-x86
>>
>> where in the (v2) of the second I just replaced /etc path with $(TARGET_OUT_ETC)
>
> No. TARGET_OUT_ETC is still the host path.
> (which is out/target/product/$target/system/etc )

I had this kind of doubt,
I think there is a precedent we can use to support original 2of2 patch (v1)

https://github.com/robherring/libpciaccess/blob/master/Android.mk

where /etc/hwdata was the folder used at runtime for pci.ids

So original 2of2 patch is signed-off by Chih-Wei and me.

Mauro

>
>> Chih-Wei if you like the (v2) could you please resubmit to dri-devel
>> using [PATCH libdrm] in the title?
>
> --
> Chih-Wei
> Android-x86 project
> http://www.android-x86.org