[PATCH libdrm] radeon: add fallthrough annotation

Michel Dänzer michel at daenzer.net
Mon Jul 31 03:05:30 UTC 2017


On 31/07/17 05:34 AM, Eric Engestrom wrote:
> GCC 7 started warning when a switch case has neither a `break` nor
> a "fallthrough" comment.
> Let's be explicit that we meant to fall through here.
> 
> Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> ---
>  radeon/radeon_surface.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c
> index 965be24c..04df77d6 100644
> --- a/radeon/radeon_surface.c
> +++ b/radeon/radeon_surface.c
> @@ -2503,6 +2503,7 @@ static int radeon_surface_sanity(struct radeon_surface_manager *surf_man,
>          if (surf->npix_y > 1) {
>              return -EINVAL;
>          }
> +        /* fallthrough */
>      case RADEON_SURF_TYPE_2D:
>          if (surf->npix_z > 1) {
>              return -EINVAL;
> 

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


P.S. Patches touching the radeon (and amdgpu) directory should (also) be
sent to the amd-gfx mailing list for review.

-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the dri-devel mailing list