[PATCH 1/6] drm/i915: Implement .get_format_info() hook for CCS

[Daniel Stone]

Hi Ben,

On 26 July 2017 at 19:07, Ben Widawsky <ben at bwidawsk.net> wrote:
> v2: Drop the 'dev' argument from the hook
>         v3: Include the description of the CCS surface layout

This went missing. Vidya's patch has it though.

> +static const struct drm_format_info ccs_formats[] = {
> +       { .format = DRM_FORMAT_XRGB8888, .depth = 24, .num_planes = 2, .cpp = { 4, 1, }, .hsub = 16, .vsub = 8, },
> +       { .format = DRM_FORMAT_XBGR8888, .depth = 24, .num_planes = 2, .cpp = { 4, 1, }, .hsub = 16, .vsub = 8, },
> +       { .format = DRM_FORMAT_ARGB8888, .depth = 32, .num_planes = 2, .cpp = { 4, 1, }, .hsub = 16, .vsub = 8, },
> +       { .format = DRM_FORMAT_ABGR8888, .depth = 32, .num_planes = 2, .cpp = { 4, 1, }, .hsub = 16, .vsub = 8, },

Mind you, this is backwards from Vidya's patch, in which CCS is
described as 8x16 subsampled rather than 16x8. I think yours is
correct though.

Cheers,
Daniel