[Intel-gfx] [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

Daniel Vetter daniel at ffwll.ch
Thu Jun 1 06:01:54 UTC 2017


On Wed, May 31, 2017 at 05:37:34PM +0100, Liviu Dudau wrote:
> On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel Vetter wrote:
> > IRQs are properly shut down, so it almost works as race-free shutdown.
> > Except the irq is stopped after the vblank stuff, so boom anyway.
> > Proper way would be to call drm_atomic_helper_shutdown before any of
> > the kms things gets stopped. So no harm in removing the
> > drm_vblank_cleanup here really.
> > 
> > Same story for both hdlcd and mali.
> > 
> > v2: Move misplaced malidp hunk to this patch (Liviu).
> > 
> > Cc: Liviu Dudau <liviu.dudau at arm.com>
> > Cc: Brian Starkey <brian.starkey at arm.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> 
> On the assumption that a subsequent patch will fix the issue highlighted in
> the commit message (doesn't have to be part of this series):
> 
> Acked-by: Liviu Dudau <liviu.dudau at arm.com>
> 
> I'm assuming that you are going to carry this patch through one of your trees,
> so I will not pull it into mali-dp tree.

Ok, applied to drm-misc-next, thanks for checking things.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list