exynos drm build failure due to cec_* symbols

[Hans Verkuil]

On 05/06/17 10:59, Russell King - ARM Linux wrote:
> On Mon, Jun 05, 2017 at 10:33:50AM +0900, Inki Dae wrote:
>> 2017년 06월 02일 22:58에 Andreas Färber 이(가) 쓴 글:
>>> Hello,
>>>
>>> We're observing the following build failure with v4.12-rc3, latest
>>> linux.git and linux-next.git:
>>>
>>> [ 9825s]   LD      vmlinux.o
>>> [ 9904s]   MODPOST vmlinux.o
>>> [ 9915s] drivers/built-in.o: In function `hdmi_get_modes':
>>> [ 9915s]
>>> /home/abuild/rpmbuild/BUILD/kernel-vanilla-4.12.rc3.51.ga374846/linux-4.12-rc3-51-ga374846/linux-obj/../drivers/gpu/drm/exynos/exynos_hdmi.c:866:
>>> undefined reference to `cec_notifier_set_phys_addr_from_edid'
>>> [ 9915s] drivers/built-in.o: In function `hdmi_remove':
>>> [ 9915s]
>>> /home/abuild/rpmbuild/BUILD/kernel-vanilla-4.12.rc3.51.ga374846/linux-4.12-rc3-51-ga374846/linux-obj/../drivers/gpu/drm/exynos/exynos_hdmi.c:1923:
>>> undefined reference to `cec_notifier_set_phys_addr'
>>> [ 9915s]
>>> /home/abuild/rpmbuild/BUILD/kernel-vanilla-4.12.rc3.51.ga374846/linux-4.12-rc3-51-ga374846/linux-obj/../drivers/gpu/drm/exynos/exynos_hdmi.c:1927:
>>> undefined reference to `cec_notifier_put'
>>> [ 9915s] drivers/built-in.o: In function `hdmi_probe':
>>> [ 9915s]
>>> /home/abuild/rpmbuild/BUILD/kernel-vanilla-4.12.rc3.51.ga374846/linux-4.12-rc3-51-ga374846/linux-obj/../drivers/gpu/drm/exynos/exynos_hdmi.c:1889:
>>> undefined reference to `cec_notifier_get'
>>> [ 9915s]
>>> /home/abuild/rpmbuild/BUILD/kernel-vanilla-4.12.rc3.51.ga374846/linux-4.12-rc3-51-ga374846/linux-obj/../drivers/gpu/drm/exynos/exynos_hdmi.c:1904:
>>> undefined reference to `cec_notifier_put'
>>> [ 9915s] drivers/built-in.o: In function `hdmi_disable':
>>> [ 9915s]
>>> /home/abuild/rpmbuild/BUILD/kernel-vanilla-4.12.rc3.51.ga374846/linux-4.12-rc3-51-ga374846/linux-obj/../drivers/gpu/drm/exynos/exynos_hdmi.c:1509:
>>> undefined reference to `cec_notifier_set_phys_addr'
>>> [ 9915s] drivers/built-in.o: In function `hdmi_detect':
>>> [ 9915s]
>>> /home/abuild/rpmbuild/BUILD/kernel-vanilla-4.12.rc3.51.ga374846/linux-4.12-rc3-51-ga374846/linux-obj/../drivers/gpu/drm/exynos/exynos_hdmi.c:827:
>>> undefined reference to `cec_notifier_set_phys_addr'
>>> [ 9931s] make[2]: ***
>>> [/home/abuild/rpmbuild/BUILD/kernel-vanilla-4.12.rc3.51.ga374846/linux-4.12-rc3-51-ga374846/Makefile:997:
>>> vmlinux] Error 1
>>> [ 9931s] make[1]: *** [Makefile:152: sub-make] Error 2
>>> [ 9931s] make: *** [Makefile:24: __sub-make] Error 2
>>>
>>> My guess is the symbols used by the exynos drm module are not exported:
>>>
>>> cec_notifier_set_phys_addr_from_edid
>>> cec_notifier_set_phys_addr
>>> cec_notifier_put
>>> cec_notifier_get
>>>
>>> Can you please look into fixing this?
>>
>> Thanks for reporting.
>>
>> Will check and fix it.
> 
> Please look at Hans' update to the way CEC's dependencies are handled.
> https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=drm-cec
> 
> These are apparently scheduled for -rc, but Mauro is busy.

They got merged in the media fixes tree, so with luck will appear in 4.12 soon.

Regards,

	Hans