[radeon-alex:amd-mainline-hybrid-4.11 91/518] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:606:4-10: preceding lock on line 604 (fwd)

[Julia Lawall]

Hello,

Please check whether holding the lock taken on line 604 past a failure
return of the function is what was intended.

thanks,
julia

---------- Forwarded message ----------
Date: Wed, 7 Jun 2017 15:06:38 +0800
From: kbuild test robot <fengguang.wu at intel.com>
To: kbuild at 01.org
Cc: Julia Lawall <julia.lawall at lip6.fr>
Subject: [radeon-alex:amd-mainline-hybrid-4.11 91/518]
    drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:606:4-10: preceding lock on
     line 604

CC: kbuild-all at 01.org
CC: dri-devel at lists.freedesktop.org
TO: Yong Zhao <yong.zhao at amd.com>
CC: Hawking Zhang <Hawking.Zhang at amd.com>

tree:   git://people.freedesktop.org/~agd5f/linux.git amd-mainline-hybrid-4.11
head:   7ccf5ab3da7a87288cc0fd11910b212e4ac154a6
commit: 5d27bff92aa139d984dd7549fb40255404cacd0c [91/518] Makefile change
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago

>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:606:4-10: preceding lock on line 604

git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
git remote update radeon-alex
git checkout 5d27bff92aa139d984dd7549fb40255404cacd0c
vim +606 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c

33f17825 Yong Zhao 2016-03-30  598
33f17825 Yong Zhao 2016-03-30  599  		while (true) {
33f17825 Yong Zhao 2016-03-30  600  			down_read(&mm->mmap_sem);
33f17825 Yong Zhao 2016-03-30  601  			ret = amdgpu_ttm_tt_get_user_pages(bo->tbo.ttm, pages);
33f17825 Yong Zhao 2016-03-30  602  			up_read(&mm->mmap_sem);
33f17825 Yong Zhao 2016-03-30  603
33f17825 Yong Zhao 2016-03-30 @604  			mutex_lock(&mem->data2.lock);
33f17825 Yong Zhao 2016-03-30  605  			if (ret != 0)
33f17825 Yong Zhao 2016-03-30 @606  				return ret;
33f17825 Yong Zhao 2016-03-30  607
33f17825 Yong Zhao 2016-03-30  608  			BUG_ON(bo != mem->data2.bo);
33f17825 Yong Zhao 2016-03-30  609

:::::: The code at line 606 was first introduced by commit
:::::: 33f17825aa7ac32c05e8df35d9b9d177af28cf91 port in all files

:::::: TO: Yong Zhao <yong.zhao at amd.com>
:::::: CC: Hawking Zhang <Hawking.Zhang at amd.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation