[PATCH 7/9] dt-bindings: media/s5p-cec.txt: document needs-hpd property
Rob Herring
robh at kernel.org
Fri Jun 9 15:31:49 UTC 2017
On Fri, Jun 9, 2017 at 9:11 AM, Hans Verkuil <hverkuil at xs4all.nl> wrote:
> On 09/06/17 16:07, Rob Herring wrote:
>> On Wed, Jun 07, 2017 at 04:46:14PM +0200, Hans Verkuil wrote:
>>> From: Hans Verkuil <hans.verkuil at cisco.com>
>>>
>>> Needed for boards that wire the CEC pin in such a way that it
>>> is unavailable when the HPD is low.
>>>
>>> Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com>
>>> Cc: Krzysztof Kozlowski <krzk at kernel.org>
>>> Cc: Andrzej Hajda <a.hajda at samsung.com>
>>> Cc: devicetree at vger.kernel.org
>>> ---
>>> Documentation/devicetree/bindings/media/s5p-cec.txt | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/s5p-cec.txt b/Documentation/devicetree/bindings/media/s5p-cec.txt
>>> index 4bb08d9d940b..261af4d1a791 100644
>>> --- a/Documentation/devicetree/bindings/media/s5p-cec.txt
>>> +++ b/Documentation/devicetree/bindings/media/s5p-cec.txt
>>> @@ -17,6 +17,12 @@ Required properties:
>>> - samsung,syscon-phandle - phandle to the PMU system controller
>>> - hdmi-phandle - phandle to the HDMI controller
>>>
>>> +Optional:
>>> + - needs-hpd : if present the CEC support is only available when the HPD
>>> + is high. Some boards only let the CEC pin through if the HPD is high, for
>>> + example if there is a level converter that uses the HPD to power up
>>> + or down.
>>
>> Seems like something common. Can you document in a common location?
>
> Should we do the same with hdmi-phandle? It is also used by CEC drivers to find
> the HDMI driver.
Yes.
> Currently only used by s5p-cec and stih-cec, but there will be more.
>
> I guess this would be a sensible place to document this:
>
> Documentation/devicetree/bindings/media/cec.txt
Sounds good. You can do this as a follow-up to this patch if you want.
For this one:
Acked-by: Rob Herring <robh at kernel.org>
More information about the dri-devel
mailing list