[PATCH 19/19] ARM: sun6i: a31s: Enable HDMI display output on the MSI Primo81 tablet

[Rob Herring]

On Fri, Jun 9, 2017 at 11:08 AM, Chen-Yu Tsai <wens at csie.org> wrote:
> On Thu, Jun 8, 2017 at 6:47 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> On Wed, Jun 7, 2017 at 6:36 PM, Rob Herring <robh at kernel.org> wrote:
>>> On Fri, Jun 02, 2017 at 09:42:19PM +0200, Maxime Ripard wrote:
>>>> On Fri, Jun 02, 2017 at 06:10:24PM +0800, Chen-Yu Tsai wrote:
>>>> > The MSI Primo81 tablet has a micro HDMI connector at the bottom.
>>>> > This is connected to the SoCs HDMI output.
>>>> >
>>>> > Enable the display pipeline and the HDMI output.
>>>> >
>>>> > Signed-off-by: Chen-Yu Tsai <wens at csie.org>
>>>> > ---
>>>> >  arch/arm/boot/dts/sun6i-a31s-primo81.dts | 25 +++++++++++++++++++++++++
>>>> >  1 file changed, 25 insertions(+)
>>>> >
>>>> > diff --git a/arch/arm/boot/dts/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/sun6i-a31s-primo81.dts
>>>> > index f3712753fa42..26154b2f87a3 100644
>>>> > --- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts
>>>> > +++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts
>>>> > @@ -52,17 +52,42 @@
>>>> >  / {
>>>> >     model = "MSI Primo81 tablet";
>>>> >     compatible = "msi,primo81", "allwinner,sun6i-a31s";
>>>> > +
>>>> > +   hdmi-connector {
>>>> > +           compatible = "hdmi-connector";
>>>> > +           type = "c";
>>>>
>>>> Should we add a connector type for this one?
>>>
>>> c as in USB Type C? I'd prefer to see a new compatible string. Is type
>>> even documented?
>
> Indeed it is:
>
> http://elixir.free-electrons.com/linux/latest/source/Documentation/devicetree/bindings/display/connector/hdmi-connector.txt#L6

-ETOOMANYBINDINGS

I guess I don't understand the original question then. This looks fine to me.

Rob