[PATCH] drm: dw-hdmi: Fix compilation breakage by selecting REGMAP_MMIO

Sean Paul seanpaul at chromium.org
Sun Jun 11 11:12:05 UTC 2017


On Sun, Jun 11, 2017 at 11:50:59AM +0530, Archit Taneja wrote:
> 
> 
> On 6/10/2017 2:29 PM, Laurent Pinchart wrote:
> > The dw-hdmi driver switched to regmap-mmio, but lacks the dependency in
> > Kconfig. This can result in compilation breakages. Fix it by selecting
> > REGMAP_MMIO.
> > 
> > Fixes: 80e2f97968b5 ("drm: bridge: dw-hdmi: Switch to regmap for register access")
> > Reported-by: kbuild test robot <fengguang.wu at intel.com>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> > ---
> >   drivers/gpu/drm/bridge/synopsys/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > Archit,
> > 
> > This is a v4.12 regression fix. While not super critical, it would be
> > nice if it could get merged in v4.12.
> 
> Sean,

Hi Archit,
I replied on irc, but looks like nobody's home.

> 
> Would you be fine with another drm-misc-fixes pull req? 

Since Dave has already sent this week's PR for -fixes, he would need to send
another one to pick up this fix. I don't think this is urgent enough to
necessitate that, so let's queue this to -misc-fixes and include it in our PR
midweek.

> It looks like
> we have a drm_of_find_panel_or_bridge() usage on imx which needs fixing
> too. If so, I can queue this to drm-misc-fixes.

Philipp (cc'd) said it's been applied to imx-fixes, so let's not step on his
toes.

Sean

> 
> Thanks,
> Archit
> 
> > 
> > diff --git a/drivers/gpu/drm/bridge/synopsys/Kconfig b/drivers/gpu/drm/bridge/synopsys/Kconfig
> > index 40d2827a6d19..53e78d092d18 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/Kconfig
> > +++ b/drivers/gpu/drm/bridge/synopsys/Kconfig
> > @@ -1,6 +1,7 @@
> >   config DRM_DW_HDMI
> >   	tristate
> >   	select DRM_KMS_HELPER
> > +	select REGMAP_MMIO
> >   config DRM_DW_HDMI_AHB_AUDIO
> >   	tristate "Synopsys Designware AHB Audio interface"
> > 
> 
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation

-- 
Sean Paul, Software Engineer, Google / Chromium OS


More information about the dri-devel mailing list