[PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

Greg Kroah-Hartman gregkh at linuxfoundation.org
Mon Jun 12 11:44:09 UTC 2017


On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
> > The most important thing is for the driver to be atomic if it's KMS
> > only, and it would be good to have someone review that properly.
> 
> I believe it does not use the atomic APIs atm, so that would be one
> of the first things to fix then. Another question is if people
> (you and Daniel at least) can live with the non kernel-coding
> style shared files under the osindependent dir ?

Why not just spend a few days and fix up all of the kernel-style issues
so it can be a "real" driver?  It shouldn't take all that long,
especially for someone with Linux kernel experience (hint, hint...)

Only put stuff in staging for a good reason, and that reason can be "I
don't know how to clean this stuff up", but I don't think that is the
case here...

thanks,

greg k-h


More information about the dri-devel mailing list