[PATCH 1/3] drm/nouveau/tegra: Skip manual unpowergating when not necessary

Ben Skeggs skeggsb at gmail.com
Mon Jun 12 22:52:14 UTC 2017


On 06/09/2017 10:25 PM, Mikko Perttunen wrote:
> On Tegra186, powergating is handled by the BPMP power domain provider
> and the "legacy" powergating API is not available. Therefore skip
> these calls if we are attached to a power domain.
Thanks Mikko,

Taken all 3 patches into my tree.

Ben.

> 
> Signed-off-by: Mikko Perttunen <mperttunen at nvidia.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> index 6474bd2a6d07..3d42cdbbe9c0 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> @@ -51,10 +51,12 @@ nvkm_device_tegra_power_up(struct nvkm_device_tegra *tdev)
>  	reset_control_assert(tdev->rst);
>  	udelay(10);
>  
> -	ret = tegra_powergate_remove_clamping(TEGRA_POWERGATE_3D);
> -	if (ret)
> -		goto err_clamp;
> -	udelay(10);
> +	if (!tdev->pdev->dev.pm_domain) {
> +		ret = tegra_powergate_remove_clamping(TEGRA_POWERGATE_3D);
> +		if (ret)
> +			goto err_clamp;
> +		udelay(10);
> +	}
>  
>  	reset_control_deassert(tdev->rst);
>  	udelay(10);
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170613/a9bebbd1/attachment.sig>


More information about the dri-devel mailing list