[PATCH v2 17/22] gpu: host1x: Correct swapped arguments in the is_addr_reg() definition

Dmitry Osipenko digetx at gmail.com
Tue Jun 13 23:15:56 UTC 2017


Arguments of the .is_addr_reg() are swapped in the definition of the
function, that is quite confusing.

Signed-off-by: Dmitry Osipenko <digetx at gmail.com>
Reviewed-by: Erik Faye-Lund <kusmabite at gmail.com>
Reviewed-by: Mikko Perttunen <mperttunen at nvidia.com>
---
 include/linux/host1x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/host1x.h b/include/linux/host1x.h
index 71a34774b56a..561d6bb6580d 100644
--- a/include/linux/host1x.h
+++ b/include/linux/host1x.h
@@ -233,7 +233,7 @@ struct host1x_job {
 	u8 *gather_copy_mapped;
 
 	/* Check if register is marked as an address reg */
-	int (*is_addr_reg)(struct device *dev, u32 reg, u32 class);
+	int (*is_addr_reg)(struct device *dev, u32 class, u32 reg);
 
 	/* Check if class belongs to the unit */
 	int (*is_valid_class)(u32 class);
-- 
2.13.0



More information about the dri-devel mailing list