[PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

Eric Anholt eric at anholt.net
Thu Jun 15 20:41:24 UTC 2017


If the panel-bridge is being set up after the drm_mode_config_reset(),
then the connector's state would never get initialized, and we'd
dereference the NULL in the hotplug path.  We also need to register
the connector, so that userspace can get at it.

Signed-off-by: Eric Anholt <eric at anholt.net>
---
 drivers/gpu/drm/bridge/panel.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 67fe19e5a9c6..8ed8a70799c7 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -82,11 +82,14 @@ static int panel_bridge_attach(struct drm_bridge *bridge)
 
 	drm_mode_connector_attach_encoder(&panel_bridge->connector,
 					  bridge->encoder);
+	drm_atomic_helper_connector_reset(&panel_bridge->connector);
 
 	ret = drm_panel_attach(panel_bridge->panel, &panel_bridge->connector);
 	if (ret < 0)
 		return ret;
 
+	drm_connector_register(&panel_bridge->connector);
+
 	return 0;
 }
 
-- 
2.11.0



More information about the dri-devel mailing list