__user with scalar data types

Gerd Hoffmann kraxel at redhat.com
Tue Jun 20 07:42:01 UTC 2017


  Hi,

> Yep that's cargo-culted, but from a quick grep only msm and qxl
> headers do this (the other __user annotations in uapi/drm are for
> pointers, where it's correct). Adding those maintainers.

Yep, those looks pointless indeed.

> Also, if you use u64_to_user_ptr helper macro sparse should have
> caught this (if not we'd need to improve the macro).

And qxl should actually use it.

Fix attached (compile-tested only so far), does that look ok?

cheers,
  Gerd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qxlfix
Type: text/x-patch
Size: 2827 bytes
Desc: 
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170620/d689d3d6/attachment.bin>


More information about the dri-devel mailing list