[Intel-gfx] [RESEND-CI v4 15/15] drm/i915/glk: set HDMI 2.0 identifier

[Sharma, Shashank]

Regards

Shashank


On 6/30/2017 5:37 PM, Ander Conselvan De Oliveira wrote:
> On Wed, 2017-06-21 at 16:04 +0530, Shashank Sharma wrote:
>> This patch sets the is_hdmi2_src identifier in drm connector
>> for GLK platform. GLK contains a native HDMI 2.0 controller.
>> This identifier will help the EDID handling functions to save
>> lot of work which is specific to HDMI 2.0 sources.
>>
>> V3: Added this patch
>> V4: Rebase
>>
>> Signed-off-by: Shashank Sharma <shashank.sharma at intel.com>
> This and patches 12 and 14 look fine to me. I'm not sure about the patch split,
> maybe they should be squashed together in the end? And perhaps patch 10 and 13
> too if the refactor I proposed are separate prep patches.
In fact this is exactly how I prepared at the first place, keeping all 
the crtc/pipe level changes together.
But then I thought the patch might be touching too many things, and 
might be too big or complex for
review, that's why I had split into 3-4 small patches :-)
>   But anyway, you can
> use
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2 at gmail.com>
>
> on those if you want.
Thanks, I guess this applies for 12,14,10,13 and 15 (with a separate 
patch for CSC coeff handling).
Please correct me if I misunderstood.

- Shashank
>
>
>> ---
>>   drivers/gpu/drm/i915/intel_hdmi.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
>> index 3bd9af3..0d9d088 100644
>> --- a/drivers/gpu/drm/i915/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
>> @@ -1979,6 +1979,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
>>   	connector->doublescan_allowed = 0;
>>   	connector->stereo_allowed = 1;
>>   
>> +	if (IS_GEMINILAKE(dev_priv))
>> +		connector->ycbcr_420_allowed = true;
>> +
>>   	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);
>>   
>>   	switch (port) {