[PATCH v1 1/1] drm/radeon: remove useless and potentially wrong message

Christian König deathsimple at vodafone.de
Mon Mar 6 12:12:13 UTC 2017


Am 01.12.2016 um 02:21 schrieb Andy Shevchenko:
> There is no need to repeat information that printed by PCI core at boot time.
>
> Besides that printing was potentially wrong since resource_size_t might be
> bigger than 32 bits and there is a dedicated specifier for such type, i.e.
> %pap. Someone can fix it and use even better approach, i.e. %pR.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/radeon/radeon_device.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
> index 60a8920..67cd59a 100644
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -1440,11 +1440,8 @@ int radeon_device_init(struct radeon_device *rdev,
>   		rdev->rmmio_size = pci_resource_len(rdev->pdev, 2);
>   	}
>   	rdev->rmmio = ioremap(rdev->rmmio_base, rdev->rmmio_size);
> -	if (rdev->rmmio == NULL) {
> +	if (rdev->rmmio == NULL)
>   		return -ENOMEM;
> -	}
> -	DRM_INFO("register mmio base: 0x%08X\n", (uint32_t)rdev->rmmio_base);
> -	DRM_INFO("register mmio size: %u\n", (unsigned)rdev->rmmio_size);
>   
>   	/* doorbell bar mapping */
>   	if (rdev->family >= CHIP_BONAIRE)




More information about the dri-devel mailing list