[PATCH] drm/i915: Nuke skl_update_plane debug message from the pipe update critical section

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Wed Mar 8 13:26:24 UTC 2017


Op 08-03-17 om 14:12 schreef Ville Syrjälä:
> On Wed, Mar 08, 2017 at 01:00:07PM +0100, Maarten Lankhorst wrote:
>> printks are slow so we should not be doing them from the vblank evade
>> critical section. These could explain why we sometimes seem to
>> blow past our 100 usec deadline.
>>
>> The problem has been there ever since commit bfd16b2a23dc ("drm/i915:
>> Make updating pipe without modeset atomic.")
> I guess that part isn't actually true as far as this printk is
> concerned?
>
> Maybe commit 331879ce8ea ("drm/i915: skylake sprite plane scaling
> using shared scalers")?
Indeed, too much copy paste. Thanks for review.

~Maarten


More information about the dri-devel mailing list