[PATCH 3/3] drm/etnaviv: submit support for out-fences

[Philipp Zabel]

On Wed, 2017-03-08 at 11:48 -0300, Gustavo Padovan wrote:
[...]
> > @@ -437,10 +447,25 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
> >  		goto out;
> >  	}
> >  
> > +	if (args->flags & ETNA_SUBMIT_FENCE_FD_OUT) {
> > +		sync_file = sync_file_create(submit->fence);
> > +		if (!sync_file) {
> > +			dma_fence_put(submit->fence);
> > +			submit->fence = NULL;
> > +			ret = -ENOMEM;
> > +			goto out;
> > +		}
> > +	}
> > +
> >  	ret = etnaviv_gpu_submit(gpu, submit, cmdbuf);
> >  	if (ret == 0)
> >  		cmdbuf = NULL;
> >  
> > +	if (args->flags & ETNA_SUBMIT_FENCE_FD_OUT) {
> > +		fd_install(out_fence_fd, sync_file->file);
> > +	}
> 
> Extra braces here.

I'll drop those next time.

> Otherwise looks good to me.
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan at collabora.com>

thanks
Philipp