[Intel-gfx] [PATCH 02/24] drm: Extract drm_prime.h

Daniel Vetter daniel at ffwll.ch
Tue Mar 14 09:12:59 UTC 2017


On Mon, Mar 13, 2017 at 12:42:54PM -0400, Sean Paul wrote:
> On Wed, Mar 08, 2017 at 03:12:35PM +0100, Daniel Vetter wrote:
> > +/**
> > + * struct drm_prime_file_private - per-file tracking for PRIME
> > + *
> > + * This just contains the internal &struct dma_buf and handle caches for each
> > + * &struct drm_file used by the PRIME core code.
> > + */
> > +
> > +struct drm_prime_file_private {
> > +/* private: */
> 
> I'm a little confused by this comment. The struct has private in its name, I'm
> not sure you're adding any additional information. Could you either remove or
> expand this?

private: is special markup for kernel-doc to ingore everything below as
implementation-internals. This avoids warnings when building the docs. I
have no idea why it doesn't use the usual /** kernel-doc comment starter
...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list