[PATCH v2] drm/atmel-hlcdc: Simplify the HLCDC layer logic

Boris Brezillon boris.brezillon at free-electrons.com
Thu Mar 16 13:29:57 UTC 2017


On Fri, 10 Feb 2017 19:07:45 +0100
Boris Brezillon <boris.brezillon at free-electrons.com> wrote:

> An HLCDC layers in Atmel's nomenclature is either a DRM plane or a 'Post
> Processing Layer' which can be used to output the results of the HLCDC
> composition in a memory buffer.
> 
> atmel_hlcdc_layer.c was designed to be generic enough to be re-usable in
> both cases, but we're not exposing the post-processing layer yet, and
> even if we were, I'm not sure the code would provide the necessary tools
> to manipulate this kind of layer.
> 
> Moreover, the code in atmel_hlcdc_{plane,layer}.c was designed before the
> atomic modesetting API, and was trying solve the
> check-setting/commit-if-ok/rollback-otherwise problem, which is now
> entirely solved by the existing core infrastructure.
> 
> And finally, the code in atmel_hlcdc_layer.c in over-complicated compared
> to what we really need. This rework is a good excuse to simplify it. Note
> that this rework solves an existing resource leak (leading to a -EBUSY
> error) which I failed to clearly identify.

Just forgot to mention that this patch has been applied to
drm-misc-next a few weeks ago.

> 
> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>


More information about the dri-devel mailing list