[PATCH] drm: add check for plane functions
Shirish S
shirish.s12 at gmail.com
Fri Mar 17 07:55:08 UTC 2017
update_plane() and disable_plane() functions
assoiciated with setting plane are called
without any check, causing kernel panic.
This patch adds the required check to avoid it.
Change-Id: I0d6792608b33e674c217388aa57c4b7d680d9bc7
Signed-off-by: Shirish S <shirish.s at amd.com>
---
drivers/gpu/drm/drm_plane.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
index 249c0ae..f675f8b 100644
--- a/drivers/gpu/drm/drm_plane.c
+++ b/drivers/gpu/drm/drm_plane.c
@@ -456,6 +456,12 @@ static int __setplane_internal(struct drm_plane *plane,
{
int ret = 0;
+ if (plane->funcs->disable_plane == NULL ||
+ plane->funcs->update_plane == NULL) {
+ DRM_ERROR("plane funcs not implemented\n");
+ ret = -EPERM;
+ goto out;
+ }
/* No fb means shut it down */
if (!fb) {
plane->old_fb = plane->fb;
--
2.7.4
More information about the dri-devel
mailing list