[PATCH] drm: vc4: remove redundant check of plane being non-null

Eric Anholt eric at anholt.net
Fri Mar 17 23:52:04 UTC 2017


Colin King <colin.king at canonical.com> writes:

> From: Colin Ian King <colin.king at canonical.com>
>
> The pointer plane is always null on the error path at label 'fail'
> hence the check if it is non-null is redundant. We can therefore
> remove the check and the destruction of plane as well as the fail
> error path and instead just return an -ENOMEM ERR_PTR.
>
> Detected by CoverityScan, CID#1339532 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

Reviewed and applied.  Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170317/fdf82292/attachment.sig>


More information about the dri-devel mailing list