[RFC PATCH 0/3] drm/panel: Pull some code out into common helpers

Emil Velikov emil.l.velikov at gmail.com
Wed Mar 22 14:36:27 UTC 2017


Hi Sean,

On 16 March 2017 at 22:08, Sean Paul <seanpaul at chromium.org> wrote:
> This series pulls out the power-sequencing code from panel-simple into a
> panel-common helper library. This allows drivers that cannot leverage
> panel-simple to share some code.
>
> I've converted the 2 sharp mipi drivers, and Chris Zhong's driver on the
> list can also be converted. I haven't checked any other drivers, but I
> suspect we'll see the same code blocks there too.
>
> I'm sure there's more we can pull out of the various drivers, but this
> seems like a good place to start talking about how to share common panel
> code across drivers.
>
Fwiw I think that the idea is good, but I'm wondering on the following
architectural questions:
 - Shouldn't prepared and enabled be part of struct drm_panel ?
 - Would it be better to subclass struct panel_common around struct drm_panel ?

I might be threading the thin line of "midlayer vs helpers" here, so
please let me know if I've got it wrong.

Thanks
Emil


More information about the dri-devel mailing list