[RFC PATCH 1/3] drm/panel: Pull common panel code out into helpers

Emil Velikov emil.l.velikov at gmail.com
Sat Mar 25 14:23:03 UTC 2017


Hi Sean,

Something small that stood out while skimming through the design.

On 16 March 2017 at 22:08, Sean Paul <seanpaul at chromium.org> wrote:

>  struct panel_simple {
>         struct drm_panel base;
> +       struct panel_common common;
> +
>         bool prepared;
>         bool enabled;
>
There two should go ?

>         const struct panel_desc *desc;
>
> -       struct backlight_device *backlight;
> -       struct regulator *supply;
>         struct i2c_adapter *ddc;
>
>         struct gpio_desc *enable_gpio;
This should go as well ?

Regards,
Emil


More information about the dri-devel mailing list