[PATCH] drm/vmwgfx: Remove getparam error message

Gustavo Padovan gustavo at padovan.org
Tue Mar 28 13:15:07 UTC 2017


Hi Thomas,

2017-03-28 Thomas Hellstrom <thellstrom at vmware.com>:

> The mesa winsys sometimes uses unimplemented parameter requests to
> check for features. Remove the error message to avoid bloating the
> kernel log.
> 
> Cc: <stable at vger.kernel.org>
> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
> Reviewed-by: Brian Paul <brianp at vmware.com>
> Reviewed-by: Sinclair Yeh <syeh at vmware.com>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> index 1802d0e..5ec24fd 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> @@ -114,8 +114,6 @@ int vmw_getparam_ioctl(struct drm_device *dev, void *data,
>  		param->value = dev_priv->has_dx;
>  		break;
>  	default:
> -		DRM_ERROR("Illegal vmwgfx get param request: %d\n",
> -			  param->param);

How about turning it into a debug message instead? Do you think it will
be useful?

Gustavo


More information about the dri-devel mailing list