[PATCHv3 04/30] drm/omap: decrease min width & height
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Mar 29 08:13:32 UTC 2017
Hi Tomi,
Thank you for the patch.
On Tuesday 28 Mar 2017 16:07:50 Tomi Valkeinen wrote:
> mode_config's min_width and min_height are both set to 32, which is
> overly restrictive.
>
> The real limits depend on whether we're configuring a crtc or a plane,
> but a limit of 8x2 is safe for both cases.
Strictly speaking it's planes in all cases, you could talk about primary or
overlay planes instead. Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
> b/drivers/gpu/drm/omapdrm/omap_drv.c index 79a4aad35e0f..fe83efbbf127
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -488,8 +488,8 @@ static int omap_modeset_init(struct drm_device *dev)
> priv->num_planes, priv->num_crtcs, priv->num_encoders,
> priv->num_connectors);
>
> - dev->mode_config.min_width = 32;
> - dev->mode_config.min_height = 32;
> + dev->mode_config.min_width = 8;
> + dev->mode_config.min_height = 2;
>
> /* note: eventually will need some cpu_is_omapXYZ() type stuff here
> * to fill in these limits properly on different OMAP generations..
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list