drivers/gpu/drm/radeon/r100.c:3303]: (style) Redundant condition

[Alex Deucher]

On Mon, Mar 27, 2017 at 6:07 AM, David Binderman <dcb314 at hotmail.com> wrote:
>
> Hello there,
>
> linux-4.11-rc4/drivers/gpu/drm/radeon/r100.c:3303]: (style) Redundant condition: If 'EXPR == 11', the comparison 'EXPR <= 12' is always true.
>
> Source code is
>
>     } else if (rdev->family == CHIP_RV350 ||
>            rdev->family <= CHIP_RV380) {
>

Fixed in the attached patch.


> Also in the same file:
>
> [drivers/gpu/drm/radeon/r100.c:2550]: (style) Variable 'tmp' is assigned a value
>  that is never used.
> [drivers/gpu/drm/radeon/r100.c:2875]: (style) Variable 'tmp' is assigned a value
>  that is never used.

These are intended.  The registers are read back to to post the previous write.

Alex
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-radeon-fix-typo-in-bandwidth-calculation.patch
Type: text/x-diff
Size: 1043 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170329/e47c3c5d/attachment.patch>