[radeon-alex:drm-next-4.12 212/315] drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c:895:1-11: second lock on line 897 (fwd)

Julia Lawall julia.lawall at lip6.fr
Fri Mar 31 11:36:10 UTC 2017


Hello,

It looks pretty clear that an unlock was intended.

julia

---------- Forwarded message ----------
Date: Fri, 31 Mar 2017 19:29:47 +0800
From: kbuild test robot <fengguang.wu at intel.com>
To: kbuild at 01.org
Cc: Julia Lawall <julia.lawall at lip6.fr>
Subject: [radeon-alex:drm-next-4.12 212/315]
    drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c:895:1-11: second
    lock on line 897


tree:   git://people.freedesktop.org/~agd5f/linux.git drm-next-4.12
head:   60508d3df2d2052881190ac82802a12cabcef53c
commit: 2a5071056e6a601efafe628a2f8162e16397ee2d [212/315] drm/amd/powerplay: add global PowerPlay mutex.
:::::: branch date: 16 hours ago
:::::: commit date: 32 hours ago

>> drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c:895:1-11: second lock on line 897
--
>> drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c:497:3-9: preceding lock on line 487

git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
git remote update radeon-alex
git checkout 2a5071056e6a601efafe628a2f8162e16397ee2d
vim +895 drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c

428bafa86 Eric Huang 2016-05-12  889
428bafa86 Eric Huang 2016-05-12  890  	if (hwmgr->hwmgr_func->set_sclk_od == NULL) {
0fb829def Huang Rui  2016-12-26  891  		pr_info("%s was not implemented.\n", __func__);
428bafa86 Eric Huang 2016-05-12  892  		return 0;
428bafa86 Eric Huang 2016-05-12  893  	}
428bafa86 Eric Huang 2016-05-12  894
2a5071056 Rex Zhu    2017-02-20 @895  	mutex_lock(&pp_handle->pp_lock);
2a5071056 Rex Zhu    2017-02-20  896  	ret = hwmgr->hwmgr_func->set_sclk_od(hwmgr, value);
2a5071056 Rex Zhu    2017-02-20 @897  	mutex_lock(&pp_handle->pp_lock);
2a5071056 Rex Zhu    2017-02-20  898  	return ret;
428bafa86 Eric Huang 2016-05-12  899  }
428bafa86 Eric Huang 2016-05-12  900

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


More information about the dri-devel mailing list