[PATCH v2 0/5] Thunderbolt GPU fixes

[Bjorn Helgaas]

On Fri, Mar 31, 2017 at 3:11 AM, Lukas Wunner <lukas at wunner.de> wrote:
> On Fri, Mar 10, 2017 at 09:23:45PM +0100, Lukas Wunner wrote:
>> Fix Thunderbolt-related issues in apple-gmux and vga_switcheroo, v2:
>>
>> Same as v1 but includes all the acks collected and in patch [1/5]
>> the commit message and a code comment were edited as requested by
>> Bjorn Helgaas.
>>
>> For details on this series please refer to the cover letter of v1:
>> https://lists.freedesktop.org/archives/dri-devel/2017-February/133891.html
>>
>> To review the patches on GitHub, use this URL:
>> https://github.com/l1k/linux/commits/thunderbolt_gpu_v2
>
> Pushed to drm-misc-next.
>
> Bjorn, I haven't heard back after my reply to your e-mail of March 10
> (regarding the "usually soldered to the mainboard" comment). I hope
> my reply was satisfactory.  If it wasn't, please feel free to amend
> the comment after the 4.12 merge window closes or alternatively send
> me a patch to fix it up.

I didn't want to needlessly prolong the discussion.  I still think
"soldered to the mainboard" is unhelpful because it contributes to a
mental model that is incorrect, namely, that Thunderbolt connectedness
is somehow related to whether the device is soldered in or removable.
I don't think it's useful to reinforce the assumption that systems
with Thunderbolt have no PCIe slots.  There's no technical reason we
can't have both, and I'm pretty sure I have an Intel box in the closet
that does.

There, I've prolonged the discussion after all :)  But it's really not
that big a deal, and you have my ack for the patch, including for the
comment, so it's OK with me to merge it as-is.

>> Lukas Wunner (5):
>>   PCI: Rhttps://cs.corp.google.com/kernel/drivers/gpu/nvidia-proprietary/nvidia/nv.c?type=cs&q=%22one+of+more+GPUs+has+fallen+off+the+bus%22&l=196ecognize Thunderbolt devices
>>   drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo
>>   drm/amdgpu: Don't register Thunderbolt eGPU with vga_switcheroo
>>   drm/nouveau: Don't register Thunderbolt eGPU with vga_switcheroo
>>   apple-gmux: Don't switch external DP port on 2011+ MacBook Pros
>>
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |  7 +++++--
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c    |  3 ++-
>>  drivers/gpu/drm/nouveau/nouveau_vga.c      | 10 +++++++++-
>>  drivers/gpu/drm/radeon/radeon_device.c     |  7 +++++--
>>  drivers/gpu/drm/radeon/radeon_kms.c        |  3 ++-
>>  drivers/pci/pci.h                          |  2 ++
>>  drivers/pci/probe.c                        | 21 ++++++++++++++++++++
>>  drivers/platform/x86/apple-gmux.c          | 31 +++++++++++++++++++++++++++++-
>>  include/linux/pci.h                        | 23 ++++++++++++++++++++++
>>  9 files changed, 99 insertions(+), 8 deletions(-)
>>
>> --
>> 2.11.0
>>