[PATCH libdrm] Export drmCompareDevices

Emil Velikov emil.l.velikov at gmail.com
Thu May 4 17:44:25 UTC 2017


On 4 May 2017 at 17:39, Adam Jackson <ajax at redhat.com> wrote:
> drmCompareBusInfo was almost this already, but it wasn't exported, its
> name didn't match its functionality, and while it almost looks like it
> was usable for sorting due to memcmp it wouldn't work if you had
> multiple bus types. I don't really want to think about defining a
> sensible sort order for bus types, so let's at least make it less of a
> trap for the caller.
>
> Invert its boolean sense to be 'true if equal', rename it to describe
> the type it actually operates on, and export.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
Makes sense.

Reviewed-by: Emil Velikov <emil.velilkov at collabora.com>

-Emil


More information about the dri-devel mailing list