[PATCH 2/2] drm/i915: Deal with upside-down mounted LCD panels

Hans de Goede hdegoede at redhat.com
Mon May 8 08:57:26 UTC 2017


Hi,

On 08-05-17 10:25, Jani Nikula wrote:
> On Sun, 07 May 2017, Hans de Goede <hdegoede at redhat.com> wrote:
>> @@ -1403,6 +1410,31 @@ static inline u32 intel_plane_ggtt_offset(const struct intel_plane_state *state)
>>   	return i915_ggtt_offset(state->vma);
>>   }
>>   
>> +static inline unsigned int
>> +intel_plane_get_rotation(const struct intel_plane_state *plane_state)
>> +{
> 
> Random drive-by bikeshed, is this really worth the inline?

It is small and this seemed a convenient way to answer the
"where to put this" question, but I'm fine with having it as
a regular function instead.

I guess it should go to intel_atomic_plane.c then?

Regards,

Hans



More information about the dri-devel mailing list