[PATCH v2 09/28] drm: omapdrm: dsi: Store DSI type and PLL hardware data in OF data

[Tomi Valkeinen]

On 08/05/17 14:32, Laurent Pinchart wrote:
> The DSI PLL hardware data and DSS channels are selected based on the
> OMAP SoC model. There's no need for fine-grained model information, as
> the driver only needs to differentiate between OMAP3, OMAP4 and OMAP5.
> As this can be done through the DSI compatible string, store the
> corresponding information in OF match data instead to avoid accessing
> the OMAP SoC model.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  drivers/gpu/drm/omapdrm/dss/dsi.c | 116 ++++++++++++++++++--------------------
>  1 file changed, 55 insertions(+), 61 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 3edd194d6f36..400f903d8197 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -227,6 +227,12 @@ static int dsi_vc_send_null(struct omap_dss_device *dssdev, int channel);
>  #define DSI_MAX_NR_ISRS                2
>  #define DSI_MAX_NR_LANES	5
>  
> +enum dsi_device_type {
> +	DSI_TYPE_OMAP3,
> +	DSI_TYPE_OMAP4,
> +	DSI_TYPE_OMAP5,
> +};

Same comment here as for the DPI. At least to me "type" doesn't sound
like what we're looking for here. If I read "switch (dsi->data->type)"
my thought is not that we're checking the DSI version. Although "DSI
version" is maybe not an exact match either... It's about how the DSI
has been integrated in that particular SoC, and which PLL version we have.

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170509/047012f0/attachment.sig>