[PATCH v2 22/28] drm: omapdrm: Move shutdown() handler from core to dss

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue May 9 21:42:23 UTC 2017


Hi Tomi,

On Tuesday 09 May 2017 14:38:39 Tomi Valkeinen wrote:
> On 08/05/17 14:32, Laurent Pinchart wrote:
> > In preparation for removal of the core module, move the shutdown()
> > handler from core to dss.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> > 
> >  drivers/gpu/drm/omapdrm/dss/core.c | 20 --------------------
> >  drivers/gpu/drm/omapdrm/dss/dss.c  | 16 ++++++++++++++++
> >  2 files changed, 16 insertions(+), 20 deletions(-)
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> 
> Although I wonder if shutdown is even needed... I think the DRM side
> should disable all the displays when being removed.

The .shutdown() handler is called when the system is shut down, including 
prior to a reboot. As far as I know the DRM core doesn't get involved there.

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list