[PATCH v2 11/28] drm: omapdrm: dss: Select features based on compatible string

Tomi Valkeinen tomi.valkeinen at ti.com
Wed May 10 06:52:31 UTC 2017



On 10/05/17 00:47, Laurent Pinchart wrote:
> Hi Tomi,
> 
> On Tuesday 09 May 2017 12:41:26 Tomi Valkeinen wrote:
>> On 08/05/17 14:32, Laurent Pinchart wrote:
>>> Use the compatible string instead of the OMAP SoC revision to determine
>>> device features. The various OMAP3-based SoCs can be told apart from the
>>> compatible string, use soc_device_match() to tell them apart.
>>
>> Here, and in a comment below, you probably mean "can _not_ be told apart
>> _using_ the compatible string".
> 
> Oops, indeed. Anything else I need to change in this patch, or do I get your 
> Reviewed-by if I fix the comment and the commit message ?

Yes:

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170510/4b4887df/attachment-0001.sig>


More information about the dri-devel mailing list